Skip to content

fix: support abc.ABCMeta in coerce_function#203

Merged
youknowone merged 1 commit intoyouknowone:mainfrom
wy-z:main
Mar 28, 2025
Merged

fix: support abc.ABCMeta in coerce_function#203
youknowone merged 1 commit intoyouknowone:mainfrom
wy-z:main

Conversation

@wy-z
Copy link
Copy Markdown
Contributor

@wy-z wy-z commented Mar 10, 2025

fix #202

@wy-z
Copy link
Copy Markdown
Contributor Author

wy-z commented Mar 11, 2025

The CI failed, but it doesn’t seem to be caused by my PR—it might be due to the black version.

Thank you! If you have time to review this PR, that would be even better.

Best wishes! @youknowone

@youknowone
Copy link
Copy Markdown
Owner

Thanks! let me check it

@youknowone
Copy link
Copy Markdown
Owner

I fixed the CI. could you rebase the PR on main?

@wy-z
Copy link
Copy Markdown
Contributor Author

wy-z commented Mar 28, 2025

I fixed the CI. could you rebase the PR on main?

It’s done. Please review again when you have a chance.

@youknowone
Copy link
Copy Markdown
Owner

Thank you. Could you add a test under tests/test_coerce.py to ensure this is working?

@wy-z
Copy link
Copy Markdown
Contributor Author

wy-z commented Mar 28, 2025

Thank you. Could you add a test under tests/test_coerce.py to ensure this is working?

Okay, I'll add unit test later

Signed-off-by: weiyang <weiyang.ones@gmail.com>
@wy-z
Copy link
Copy Markdown
Contributor Author

wy-z commented Mar 28, 2025

Thank you. Could you add a test under tests/test_coerce.py to ensure this is working?

tests/test_coerce.py::test_coerce[User-User] PASSED [ 15%]
tests/test_coerce.py::test_coerce[ABCUser-ABCUser] PASSED [ 15%]

Copy link
Copy Markdown
Owner

@youknowone youknowone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@youknowone youknowone merged commit 7fbd8b8 into youknowone:main Mar 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

type '<class 'abc.ABCMeta'>' is not a key-compatible type

2 participants